This repository has been archived by the owner on Jan 24, 2021. It is now read-only.
Fix for issue #680 + another fix #722
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try and fix InvalidOperationException occurring in this method (Issue #680)
Path.GetExtension includes the period.
|
Could you send on PR per feature? Makes it a lot easier for to review and triage. Thanks! |
|
Hmmm.. I'd love to but can't work out how! |
|
Sorry, I can't work out how to split these 2 commits into separate pull requests. They're pretty small changes... |
thecodejunkie
added a commit
to thecodejunkie/Nancy
that referenced
this pull request
Oct 8, 2012
grumpydev
added a commit
that referenced
this pull request
Oct 8, 2012
Replace fix for #722 (should be closed)
|
Fixed in #779 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit b8e7f18 fixes a bug with usage of Path.GetExtension(..) which caused routes to be truncated unexpectedly if you included a filename extension.
Commit 03f92e1 is to fix an "enumeration was modified" exception in the AspNet Hosting (see issue #680). I'm not 100% sure why this was required but I suspect the problem might've arisen if the request was aborted before the response was sent. This fix has certainly worked in our environment and isn't very intrusive.